RFR (S): 8067868: Add GCOld as a JTreg test

Kim Barrett kim.barrett at oracle.com
Thu Dec 18 21:25:34 UTC 2014


On Dec 18, 2014, at 7:45 AM, Bengt Rutisson <bengt.rutisson at oracle.com> wrote:
> 
> Could I have a couple of reviews for this change to make GCOld a JTreg test?
> 
> Root repo changes:
> http://cr.openjdk.java.net/~brutisso/8067868/root-webrev.00/
> 
> HotSpot repo changes:
> http://cr.openjdk.java.net/~brutisso/8067868/hotspot-webrev.00/
> 
> Bug report:
> https://bugs.openjdk.java.net/browse/JDK-8067868

------------------------------------------------------------------------------
test/stress/gc/TestGCOld.java

  31  * @run main/othervm -Xmx384M -XX:+UseParallelGC TestGCOld 50 1 20 10 10000
  32  * @run main/othervm -Xmx384M -XX:+UseParallelGC -XX:-UseParallelOldGC TestGCOld 50 1 20 10 10000

I think line 31 contains the implicit assumption that
-XX:+UseParallelOldGC is the default?  I think it would be better to
make that explicit.

And I' not sure what collector get's used for line 32.  Is it serial?

Maybe line 31 should just be -XX:+UseParallelOldGC (which implies
-XX:+UseParallelGC).  And line 32 should be replaced by a set of lines
of -XX:+UseParallelGC -XX:+Use{oldspace gc compatible with parallel young}.

I didn't really look at the details of the test itself.  I assume it
came from elsewhere, more or less unchanged except for the jtreg
header comment?

------------------------------------------------------------------------------ 
test/TEST.groups

 444 hotspot_jprt = \
 ...
 451   :hotspot_gc_gcold \
 ...

I'm surprised a "stress" test is being added to the jprt set.

------------------------------------------------------------------------------



More information about the hotspot-gc-dev mailing list