RFR (S): 8067868: Add GCOld as a JTreg test

Dmitry Fazunenko dmitry.fazunenko at oracle.com
Fri Dec 19 13:36:18 UTC 2014


Hi Bengt,

I didn't try to understand the logic in detail, I think this is not new 
test.
What I noticed:
- the code doesn't meet java coding style (indent should be 4)
- checkTrees()method is declared, but all invocations are commented out. 
If we don't need the method we can remove it
- this test never fails (only if OOM or crash). Is it expected?

Thanks,
Dima


On 18.12.2014 15:45, Bengt Rutisson wrote:
>
> Hi everyone,
>
> Could I have a couple of reviews for this change to make GCOld a JTreg 
> test?
>
> Root repo changes:
> http://cr.openjdk.java.net/~brutisso/8067868/root-webrev.00/
>
> HotSpot repo changes:
> http://cr.openjdk.java.net/~brutisso/8067868/hotspot-webrev.00/
>
> Bug report:
> https://bugs.openjdk.java.net/browse/JDK-8067868
>
> Thanks,
> Bengt



More information about the hotspot-gc-dev mailing list