RFR (S): 8067868: Add GCOld as a JTreg test
bengt.rutisson at oracle.com
Fri Dec 19 14:15:29 UTC 2014
Thanks for looking at this.
On 2014-12-19 14:36, Dmitry Fazunenko wrote:
> Hi Bengt,
> I didn't try to understand the logic in detail, I think this is not
> new test.
> What I noticed:
> - the code doesn't meet java coding style (indent should be 4)
> - checkTrees()method is declared, but all invocations are commented
> out. If we don't need the method we can remove it
> - this test never fails (only if OOM or crash). Is it expected?
Yes, just as you noted this is not a new test. I only moved it. I would
prefer to not move it and change it at the same time. This review is
just about moving the test into JTreg. Once it is there we can start
cleaning it up.
> On 18.12.2014 15:45, Bengt Rutisson wrote:
>> Hi everyone,
>> Could I have a couple of reviews for this change to make GCOld a
>> JTreg test?
>> Root repo changes:
>> HotSpot repo changes:
>> Bug report:
More information about the hotspot-gc-dev