RFR (S): 8067868: Add GCOld as a JTreg test

Kim Barrett kim.barrett at oracle.com
Mon Dec 29 20:02:10 UTC 2014


On Dec 19, 2014, at 9:28 AM, Bengt Rutisson <bengt.rutisson at oracle.com> wrote:
> 
>> test/stress/gc/TestGCOld.java
>> 
>>   31  * @run main/othervm -Xmx384M -XX:+UseParallelGC TestGCOld 50 1 20 10 10000
>>   32  * @run main/othervm -Xmx384M -XX:+UseParallelGC -XX:-UseParallelOldGC TestGCOld 50 1 20 10 10000
>> 
>> I think line 31 contains the implicit assumption that
>> -XX:+UseParallelOldGC is the default?  I think it would be better to
>> make that explicit.
> 
> I think the normal way of selecting the ParallelGC is to use -XX:+UseParallelGC. This implies the ParallelOldGC. When we ask people to run the parallel collector I think we normally just tell them to run with -XX:+UseParallelGC. So, to me it is easier to read it as it is now. Adding more flags makes me have to look closer to see why they are there.

Oops, I was looking at old (jdk7) documentation; things are different in jdk8+.  Sorry for the noise.

>> ------------------------------------------------------------------------------
>> test/TEST.groups
>> 
>>  444 hotspot_jprt = \
>>  ...
>>  451   :hotspot_gc_gcold \
>>  ...
>> 
>> I'm surprised a "stress" test is being added to the jprt set.
>> 
>> ------------------------------------------------------------------------------
>> 
> 
> GCOld was always run in JPRT. I just moved it into the JTreg harness. I figured it is a kind of different test than the normal tests we have had there until now. That's why I called it stress. I'm planning to move one more test in there too - GCBasher.

OK.

Change looks good to me.



More information about the hotspot-gc-dev mailing list