RFR (XXS): 8033545: Missing volatile specifier in Bitmap::par_put_range_within_word

Bengt Rutisson bengt.rutisson at oracle.com
Wed Feb 5 01:08:42 PST 2014


Hi Thomas and Matthias,

The change looks good.

But just to be clear. The original suggestion was to make pw volatile, 
but instead you fixed it by using the return value of 
Atomic::cmpxchg_ptr(). I think that is fine, but I wanted to make sure 
that I understood the fix properly. Or did I miss something? If my 
understanding is correct we should maybe update the CR with a comment 
saying that it was fixed in a different way.

Thanks for filing the CR to track down similar issues.

Bengt

On 2/5/14 9:28 AM, Thomas Schatzl wrote:
> Hi all,
>
>    can I have reviews for the following small change that fixes incorrect
> reload of the original value of a CAS target in
> Bitmap::par_put_range_within_word?
>
> Contributed by Matthias Braun from SAP.
>
> (Which means we have a the review stamp from me already).
>
> There seem to be more of these issues in the GC code, a first attempt to
> catch them is recorded in JDK-8033552.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8033545
>
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8033545/webrev/
>
> Testing:
> jprt
>
> Thanks,
>    Thoams
>



More information about the hotspot-gc-dev mailing list