RFR: 8033764: Remove the usage of StarTask from BufferingOopClosure

Stefan Karlsson stefan.karlsson at oracle.com
Mon Feb 10 02:53:23 PST 2014


Hi Thomas,

On 2014-02-10 11:23, Thomas Schatzl wrote:
> Hi Stefan,
>
> On Thu, 2014-02-06 at 16:58 +0100, Stefan Karlsson wrote:
>> New webrevs:
>>
>> http://cr.openjdk.java.net/~stefank/8033764/webrev.01.delta/
>> http://cr.openjdk.java.net/~stefank/8033764/webrev.01
>>
>> - Fixed most review comments. Waiting for more comments before
>> deciding on void* vs OopOrNarrowOopStar.
>> - Fixed a copy-n-paste error in the tests:
>> -        case 1:  oops_do_narrow_then_full(cl);
>> +        case 1:
>> +          oops_do_full_then_narrow(cl);
>>
>   looks okay.
>
> Some comments:
> - copyright dates for jni.cpp and g1RemSet.cpp still read 2013
> - I would prefer the use of OopOrNarrowOopStar although it is just a
> void*
> - could you add the comment about why StarTask is not used here, i.e.
> that oops embedded in code are not aligned, preventing us to use
> StarTask here? I.e. the comment from
> G1CollectedHeap::g1_process_strong_roots().

Thanks for reviewing.

I've addressed all your comments:
http://cr.openjdk.java.net/~stefank/8033764/webrev.02.delta/
http://cr.openjdk.java.net/~stefank/8033764/webrev.02/

thanks,
StefanK

>
> Thanks,
>    Thomas
>
>



More information about the hotspot-gc-dev mailing list