RFR: 8033764: Remove the usage of StarTask from BufferingOopClosure

Stefan Karlsson stefan.karlsson at oracle.com
Mon Feb 10 04:13:51 PST 2014


On 2014-02-10 13:15, Thomas Schatzl wrote:
> Hi Stefan,
>
> On Mon, 2014-02-10 at 11:53 +0100, Stefan Karlsson wrote:
>> Hi Thomas,
>>
>> On 2014-02-10 11:23, Thomas Schatzl wrote:
>>> Hi Stefan,
>>>
>>>    looks okay.
>>>
>>> Some comments:
>>> - copyright dates for jni.cpp and g1RemSet.cpp still read 2013
>>> - I would prefer the use of OopOrNarrowOopStar although it is just a
>>> void*
>>> - could you add the comment about why StarTask is not used here, i.e.
>>> that oops embedded in code are not aligned, preventing us to use
>>> StarTask here? I.e. the comment from
>>> G1CollectedHeap::g1_process_strong_roots().
>> Thanks for reviewing.
>>
>> I've addressed all your comments:
>> http://cr.openjdk.java.net/~stefank/8033764/webrev.02.delta/
>> http://cr.openjdk.java.net/~stefank/8033764/webrev.02/
>>
> Looks good,

Thanks!

I'm going to push this now.

StefanK

>    Thomas
>
>



More information about the hotspot-gc-dev mailing list