RFR: 8034764: Use process_strong_roots to adjust the StringTable

Thomas Schatzl thomas.schatzl at oracle.com
Wed Feb 12 06:22:00 PST 2014


Hi,

On Wed, 2014-02-12 at 11:09 +0100, Stefan Karlsson wrote:
> Hi all,
> 
> Please, review this patch to reuse process_strong_roots for StringTable 
> pointer adjustment during the GenMarkSweep and G1MarkSweep adjust phases.
> 
> Webrev:
> http://cr.openjdk.java.net/~stefank/8034764/webrev.00/
> 
> RFE:
> https://bugs.openjdk.java.net/browse/JDK-8034764

- The comment in sharedHeap.hpp for process_weak_roots() mentions that
it processes the string table still.

-  // Apply "root_closure" to all the weak roots of the system.

also "*all* weak roots" seems to be wrong too (was probably before
already too).

Other than that, looks okay.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list