RFR: 8034764: Use process_strong_roots to adjust the StringTable

Stefan Karlsson stefan.karlsson at oracle.com
Wed Feb 12 06:28:53 PST 2014


Hi Thomas,

On 12/02/14 15:22, Thomas Schatzl wrote:
> Hi,
>
> On Wed, 2014-02-12 at 11:09 +0100, Stefan Karlsson wrote:
>> Hi all,
>>
>> Please, review this patch to reuse process_strong_roots for StringTable
>> pointer adjustment during the GenMarkSweep and G1MarkSweep adjust phases.
>>
>> Webrev:
>> http://cr.openjdk.java.net/~stefank/8034764/webrev.00/
>>
>> RFE:
>> https://bugs.openjdk.java.net/browse/JDK-8034764
> - The comment in sharedHeap.hpp for process_weak_roots() mentions that
> it processes the string table still.
>
> -  // Apply "root_closure" to all the weak roots of the system.
>
> also "*all* weak roots" seems to be wrong too (was probably before
> already too).
>
> Other than that, looks okay.

Thanks.

Here's the update webrevs:
http://cr.openjdk.java.net/~stefank/8034764/webrev.01/
http://cr.openjdk.java.net/~stefank/8034764/webrev.01.delta/

StefanK

>
> Thanks,
>    Thomas
>
>



More information about the hotspot-gc-dev mailing list