RFR: 8034764: Use process_strong_roots to adjust the StringTable

Bengt Rutisson bengt.rutisson at oracle.com
Thu Feb 13 08:09:10 PST 2014


Hi Stefan,

Looks good as far as I can tell.

Bengt

On 2/12/14 3:28 PM, Stefan Karlsson wrote:
> Hi Thomas,
>
> On 12/02/14 15:22, Thomas Schatzl wrote:
>> Hi,
>>
>> On Wed, 2014-02-12 at 11:09 +0100, Stefan Karlsson wrote:
>>> Hi all,
>>>
>>> Please, review this patch to reuse process_strong_roots for StringTable
>>> pointer adjustment during the GenMarkSweep and G1MarkSweep adjust 
>>> phases.
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~stefank/8034764/webrev.00/
>>>
>>> RFE:
>>> https://bugs.openjdk.java.net/browse/JDK-8034764
>> - The comment in sharedHeap.hpp for process_weak_roots() mentions that
>> it processes the string table still.
>>
>> -  // Apply "root_closure" to all the weak roots of the system.
>>
>> also "*all* weak roots" seems to be wrong too (was probably before
>> already too).
>>
>> Other than that, looks okay.
>
> Thanks.
>
> Here's the update webrevs:
> http://cr.openjdk.java.net/~stefank/8034764/webrev.01/
> http://cr.openjdk.java.net/~stefank/8034764/webrev.01.delta/
>
> StefanK
>
>>
>> Thanks,
>>    Thomas
>>
>>
>



More information about the hotspot-gc-dev mailing list