RFR (S): 8035326: Assume non-NULL references in G1CollectedHeap::in_cset_fast_test
jon.masamitsu at oracle.com
Wed Feb 19 17:18:07 PST 2014
Changes look good.
Is there really nothing you would put into the assert string?
+ assert(_g1_committed.contains((HeapWord*) obj), "");
On 2/19/2014 7:12 AM, Thomas Schatzl wrote:
> Hi all,
> can I get reviews for the following change that lifts the assumption
> that the oop* passed to G1CollectedHeap::in_cset_fast_test is non-null,
> allowing manual optimization of code.
> Almost all uses of G1CollectedHeap::in_cset_fast_test() already made
> sure that non-null references are passed to it. The only remaining one,
> in G1ParCopyClosure::do_oop_work() actually benefits from lifting this
> restriction by allowing removal of some additional checks.
> Also removes another superfluous check in the same method.
> This is based on the change for 8027559.
More information about the hotspot-gc-dev