RFR (S): 8027559: Decrease code size and templatizing in G1ParCopyClosure::do_oop_work

Stefan Karlsson stefan.karlsson at oracle.com
Thu Feb 20 00:50:38 PST 2014


On 2014-02-19 16:12, Thomas Schatzl wrote:
> Hi all,
>
>    after the feedback from Stefan K. I split up the original change into
> multiple changesets
> (http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2014-February/009440.html).
>
> I agree, as Stefan indicated, it makes reviewing easier.
>
> Here is the first part.
>
> Changes included:
>
> - removed the unused _during_initial_mark, _mark_in_progress, _g1_rem
> members from G1ParClosureSuper
> - moved G1ParClosureSuper::_cm into G1ParCopyHelper as it is only used
> there
> - moved G1ParCopyClosure::mark_[forwarded_]object from G1ParCopyClosure
> into G1ParCopyHelper to avoid the multiple instantiations of these
> methods.
> - some minor cleanup
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8027559
>
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8027559/webrev.1/

Nice cleanup. Thanks for splitting this up into separate changesets.

Looks good.

StefanK

>
> Testing:
> jprt
>
> Thanks,
>    Thomas
>



More information about the hotspot-gc-dev mailing list