RFR (S): 8035329: Move G1ParCopyClosure::copy_to_survivor_space into G1ParScanThreadState

Stefan Karlsson stefan.karlsson at oracle.com
Thu Feb 20 01:11:49 PST 2014


Hi Thomas,

On 2014-02-19 16:12, Thomas Schatzl wrote:
> Hi all,
>
>    can I have reviews for the following change that moves
> G1ParCopyClosure::copy_to_survivor_space() into G1ParScanThreadState.
>
> The previous location of G1ParCopyClosure::copy_to_survivor_space() was
> bad because although it did not depend on any template parameters, it
> was there, resulting in additional duplicate code.
>
> As for the new destination, G1ParScanThreadState seemed to be the best
> candidate because the method references it a lot (calling a few methods
> from it).
>
> Also, the next change for JDK-8035330 also depends on _scanner being
> available in G1ParScanThreadState.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8035329
>
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8035329/webrev/

This patch doesn't look complete. It doesn't remove _scanner and 
copy_to_survivor_space from G1ParCopyClosure.

StefanK

>
> Based on the changes for 8035326 recently posted here.
>
> Testing:
> jprt
>
> Thanks,
>    Thomas
>
>



More information about the hotspot-gc-dev mailing list