RFR (S): 8035326: Assume non-NULL references in G1CollectedHeap::in_cset_fast_test

Thomas Schatzl thomas.schatzl at oracle.com
Thu Feb 20 02:17:39 PST 2014


Hi Jon,

  thanks for the review.

On Wed, 2014-02-19 at 17:18 -0800, Jon Masamitsu wrote:
> Thomas,
> 
> Changes look good.
> 
> Is there really nothing you would put into the assert string?
> 
> http://cr.openjdk.java.net/~tschatzl/8035326/webrev/src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp.udiff.html
> 
> +    assert(_g1_committed.contains((HeapWord*) obj), "");
> 

Fixed in http://cr.openjdk.java.net/~tschatzl/8035326/webrev.1 along
with other suggestions from Stefan.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list