RFR (S): 8027295: Free CSet takes ~50% of young pause time

Thomas Schatzl thomas.schatzl at oracle.com
Tue Feb 25 05:51:44 PST 2014


Hi Stefan,

On Mon, 2014-02-24 at 14:15 +0100, Stefan Karlsson wrote:
> Hi Thomas,
> 
> Not a full review, but a comment below:
> 
> On 2014-02-24 12:40, Thomas Schatzl wrote:
> > Hi all,
> >
> >    can I have reviews for the remaining parts of 8027295 after splitting
> > out code cache remembered set data structure changes (JDK-8025406)?
> >
> > It only includes several smaller changes around CSet freeing that
> > improve performance.
> >
> > Note that this change is based on 8035406 also out for review
> >
> > Changes:
> >
> > - fast card cache changes
> >    - pad FCC rows to cache line size to avoid any false sharing (every
> > row represents the card cache for a single worker thread)
> 
> Is it really enough to just pad the size and not the start address of 
> >
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8027295
> >
> > Webrev:
> > http://cr.openjdk.java.net/~tschatzl/8027295/webrev.2/

Fixed in

http://cr.openjdk.java.net/~tschatzl/8027295/webrev.3/

Sorry.

Thanks,
Thomas



More information about the hotspot-gc-dev mailing list