RFR(S): 8035822 - Unable to test minimalVM

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Wed Feb 26 04:56:52 PST 2014


David Holmes skrev 26/2/14 13:28:
> On 26/02/2014 9:31 PM, Jesper Wilhelmsson wrote:
>> Hi,
>>
>> Could I have a few reviews of this small change?
>
> A few? :)

OK, two is enough I guess :-)

>
> Looks good to me - thanks for detecting and fixing this.

Thanks for the review!
This was detected by StefanK so all credit should go to him.
/Jesper

>
> David
>
>> A few lines of unit test code ended up on the wrong side of an #ifdef
>> INCLUDE_ALL_GCS leading to errors when running the minimal VM.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8035822
>>
>> Webrev: http://cr.openjdk.java.net/~jwilhelm/8035822/webrev/
>>
>> Thanks,
>> /Jesper


More information about the hotspot-gc-dev mailing list