Request for review (s) - 7098155: Resize young gen at full collections for UseParallelGC

Tao Mao yiyeguhu at gmail.com
Wed Feb 26 13:51:35 PST 2014


Hi Jon,

Just a comment on comment:

        // Swap the survivor spaces if from_space is empty. The
        // resize_young_gen() called below is normally used after
        // a successful young GC and expects the survivor spaces
        // have been swapped.

->

        // Swap the survivor spaces if from_space is empty. The
        // resize_young_gen() called below is normally used after
        // a successful young GC and swapping of survivor spaces;
        // otherwise, it won't succeed to resize young gen under
        // the current mechanism

Is it clearer?

Thanks.
Tao



On Wed, Feb 26, 2014 at 1:27 PM, Jon Masamitsu <jon.masamitsu at oracle.com>wrote:

> 7098155: Resize young gen at full collections for UseParallelGC
>
> This change adds the call to resize_young_gen() to resize the young
> generation
>  after a full collection.
>
> http://cr.openjdk.java.net/~jmasa/7098155/webrev.00/
>
> This is the CR I inherited from Tao.  I changed his original patch
> to remove the flag that originally guarded the change.  The flag
> was put in because we originally thought this would go into
> the jdk8 release rather late and considered it safer to guard
> the change.
>
> Jon
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20140226/efc19e1b/attachment.html 


More information about the hotspot-gc-dev mailing list