Request for review (s) - 7098155: Resize young gen at full collections for UseParallelGC

Jon Masamitsu jon.masamitsu at oracle.com
Wed Feb 26 14:17:27 PST 2014


On 2/26/2014 1:51 PM, Tao Mao wrote:
> Hi Jon,
>
> Just a comment on comment:
>
>          // Swap the survivor spaces if from_space is empty. The
>          // resize_young_gen() called below is normally used after
>          // a successful young GC and expects the survivor spaces
>          // have been swapped.
> ->
>          // Swap the survivor spaces if from_space is empty. The
>          // resize_young_gen() called below is normally used after
>          // a successful young GC and swapping of survivor spaces;
>          // otherwise, it won't succeed to resize young gen under
>          // the current mechanism
> Is it clearer?

Yes, I will add it.  Thanks.

Jon

>
> Thanks.
> Tao
>
>
>
> On Wed, Feb 26, 2014 at 1:27 PM, Jon Masamitsu 
> <jon.masamitsu at oracle.com <mailto:jon.masamitsu at oracle.com>> wrote:
>
>     7098155: Resize young gen at full collections for UseParallelGC
>
>     This change adds the call to resize_young_gen() to resize the
>     young generation
>      after a full collection.
>
>     http://cr.openjdk.java.net/~jmasa/7098155/webrev.00/
>     <http://cr.openjdk.java.net/%7Ejmasa/7098155/webrev.00/>
>
>     This is the CR I inherited from Tao.  I changed his original patch
>     to remove the flag that originally guarded the change.  The flag
>     was put in because we originally thought this would go into
>     the jdk8 release rather late and considered it safer to guard
>     the change.
>
>     Jon
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20140226/a7367eaf/attachment.html 


More information about the hotspot-gc-dev mailing list