RFR(S): 8035822 - Unable to test minimalVM

Erik Helin erik.helin at oracle.com
Wed Feb 26 22:07:27 PST 2014


Hi Jesper,

looks good.

Thanks,
Erik

On 02/26/2014 11:46 PM, Jesper Wilhelmsson wrote:
> Stefan Karlsson skrev 26/2/14 23:32:
>> On 2014-02-26 23:08, Jesper Wilhelmsson wrote:
>>> Hi again,
>>>
>>> There have been a lot of new unit tests added in jdk9 so this change
>>> did not
>>> apply cleanly to jdk8. Therefore I'm obliged to ask for a second
>>> round of
>>> reviews to backport this trivial change. Sorry for the inconvenience.
>>>
>>> Webrev: http://cr.openjdk.java.net/~jwilhelm/8035822/webrev.jdk8u/
>>
>> You moved the call into INCLUDE_VM_STRUCTS instead of INCLUDE_ALL_GCS:
>
> I should probably just go to bed...
>
> New webrev: http://cr.openjdk.java.net/~jwilhelm/8035822/webrev.jdk8u.2/
>
> Thanks,
> /Jesper
>
>>
>> -    run_unit_test(TestOldFreeSpaceCalculation_test());
>>   #if INCLUDE_VM_STRUCTS
>> +    run_unit_test(TestOldFreeSpaceCalculation_test());
>>       run_unit_test(VMStructs::test());
>>   #endif
>>
>>
>> StefanK
>>
>>>
>>> Thanks,
>>> /Jesper
>>>
>>>
>>> Jesper Wilhelmsson skrev 26/2/14 12:31:
>>>> Hi,
>>>>
>>>> Could I have a few reviews of this small change?
>>>>
>>>> A few lines of unit test code ended up on the wrong side of an #ifdef
>>>> INCLUDE_ALL_GCS leading to errors when running the minimal VM.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8035822
>>>>
>>>> Webrev: http://cr.openjdk.java.net/~jwilhelm/8035822/webrev/
>>>>
>>>> Thanks,
>>>> /Jesper
>>


More information about the hotspot-gc-dev mailing list