RFR (XXS): JDK-8049327: [TESTBUG] gc/logging/TestGCId.java assumes default PrintGCID value is true

Bengt Rutisson bengt.rutisson at oracle.com
Mon Jul 7 12:52:16 UTC 2014



On 2014-07-07 10:45, Erik Helin wrote:
> On Monday 07 July 2014 10:02:37 AM Bengt Rutisson wrote:
>> Hi everyone,
>>
>> Can I have a couple of reviews for this very small fix?
>>
>> http://cr.openjdk.java.net/~brutisso/8049327/webrev.00/
>>
>> https://bugs.openjdk.java.net/browse/JDK-8049327
> Looks good, Reviewed.

Thanks, Erik.

Got an off-line review from Thomas. All set to push this now.

Bengt

>
> Thanks,
> Erik
>
>> When I backported the PrintGCID fix from JDK 9 to the 8u repo I changed
>> the default value to false for this flag. But I forgot to update the
>> test. The proposed patch simply changes the expected default behavior to
>> be false for PrintGCID.
>>
>> Thanks,
>> Bengt



More information about the hotspot-gc-dev mailing list