RFR (S): 8048112: G1 Full GC needs to support the case when the very first region is not available

Kim Barrett kim.barrett at oracle.com
Fri Jul 11 21:06:10 UTC 2014


On Jul 10, 2014, at 5:18 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
> 
>> g1CollectedHeap.hpp
>> 
>> I assume the added const qualifier for n_regions() is because there is
>> some caller that now requires this.  There are several nearby
>> functions that look like they ought to be similarly qualified, but
>> aren't, and that looks strange and confusing when first coming upon
>> this code.
> 
> Done. Thanks for thinking of fitting code improvements beyond the
> change.

And now we have a similar issue in HeapRegionSetBase, with length() looking lonely in its const-ness.

Unfortunately, late const-ness fixups do tend to propagate.  I think it would stop at HeapRegionSetBase in this case though.  Your call as to whether to continue the cleanup chain unrelated to the real purpose of this change set, or do cleanups in another changeset.



More information about the hotspot-gc-dev mailing list