RFR (S): 8048112: G1 Full GC needs to support the case when the very first region is not available

Bengt Rutisson bengt.rutisson at oracle.com
Tue Jul 15 11:00:02 UTC 2014


Hi Thomas,

Latest webrev looks good to me too.

Thanks,
Bengt


On 2014-07-14 20:01, Kim Barrett wrote:
> On Jul 14, 2014, at 4:14 AM, Thomas Schatzl <thomas.schatzl at oracle.com> wrote:
>>> And now we have a similar issue in HeapRegionSetBase, with length() looking
>>> lonely in its const-ness.
>>>
>>> Unfortunately, late const-ness fixups do tend to propagate.  I think it would
>>> stop at HeapRegionSetBase in this case though.  Your call as to whether
>>> to continue the cleanup chain unrelated to the real purpose of this
>>> change set, or do cleanups in another changeset.
>> If you do not mind I would like to stop fixing const'ness at this point;
>> imo there is so much that I would like to change about the current heap
>> region sets that I want to revisit them rather sooner than later anyway.
>>
>> E.g. you could continue arguing that some FreeRegionList methods should
>> be constified as well etc.
>>
>> I updated JDK-6949241 with current ideas about that, sort-of-hijacking
>> that CR…
> I’m OK with that.  Other than that, looks good.
>



More information about the hotspot-gc-dev mailing list