RFR (S): 8051973: Eager reclaim leaves marks of marked but reclaimed objects on the next bitmap

Jon Masamitsu jon.masamitsu at oracle.com
Tue Jul 29 20:50:32 UTC 2014


On 7/29/2014 3:40 AM, Thomas Schatzl wrote:
> Hi all,
>
>    can I have reviews for the following small change?
>
> JDK-8027959 implemented eager reclaim of humongous objects, which
> potentially left stray set marks on the mark bitmap after reclaiming a
> region.
>
> This change fixes this.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8051973
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8051973/webrev/

The changes look good.

You left the uses  r->bottom() so you would not
have to cast obj to HeapWord*?

Do you want to specify a region size in the test?  Current
policy would have  regions sizes such that

   48     public static final int M = 1024*1024;

gives you humongous allocations but policy could change, yes?

Jon

> Testing:
> jprt, failing test case, new jtreg test case
>
> Thanks,
>    Thomas
>
>



More information about the hotspot-gc-dev mailing list