RFR (S): 8051973: Eager reclaim leaves marks of marked but reclaimed objects on the next bitmap
jon.masamitsu at oracle.com
Wed Jul 30 14:28:16 UTC 2014
On 07/30/2014 04:29 AM, Thomas Schatzl wrote:
> Hi Jon,
> thanks for the review.
> On Tue, 2014-07-29 at 13:50 -0700, Jon Masamitsu wrote:
>> On 7/29/2014 3:40 AM, Thomas Schatzl wrote:
>>> Hi all,
>>> can I have reviews for the following small change?
>>> JDK-8027959 implemented eager reclaim of humongous objects, which
>>> potentially left stray set marks on the mark bitmap after reclaiming a
>>> This change fixes this.
>> The changes look good.
>> You left the uses r->bottom() so you would not
>> have to cast obj to HeapWord*?
> Yes. If you have objections to that I can change that back. The code is
> easier to read for me if there is not that much casting.
Don't change it back. I like the introduction of "obj". I just
wasn't sure why it was not used in other places to replace
r->bottom(). To avoid casts (a good thing) is sufficient
>> Do you want to specify a region size in the test? Current
>> policy would have regions sizes such that
>> 48 public static final int M = 1024*1024;
>> gives you humongous allocations but policy could change, yes?
> Full webrev:
More information about the hotspot-gc-dev