RFR (L) 8034246: remove CMS and ParNew adaptive size policy code

Thomas Schatzl thomas.schatzl at oracle.com
Tue May 6 08:45:12 UTC 2014


Hi John,

On Mon, 2014-05-05 at 09:14 -0700, John Coomes wrote:
> I'd appreciate reviews of this change to delete unused adaptive size
> policy code for cms and parnew.  It's big in terms of line count, but
> most comes from the deletion of 6 files.
> 
> http://cr.openjdk.java.net/~jcoomes/8034246-rm-cms-asp/
> 
> -John


  some notes:

- the GCPauseTimer class can be removed now too I think. This change
removes its last uses.

- in CMSCollector::reset(), I am not sure why the
AdaptiveSizePolicyOutput use has been removed, and the change in
AdaptiveSizePolicyOutput::print_test(). Same in
GenCollectedHeap::do_collection(). If that is intendeded, can we remove
the local "sp" variable in CMSCollector::reset(), i.e. inline it? It's
only used once quite far below.
That's just a suggestion, I am fine with either way.

Otherwise looks good.

Thanks,
Thomas




More information about the hotspot-gc-dev mailing list