RFR (L) 8034246: remove CMS and ParNew adaptive size policy code

Mikael Gerdin mikael.gerdin at oracle.com
Tue May 6 08:52:08 UTC 2014


John,

On Monday 05 May 2014 09.14.40 John Coomes wrote:
> I'd appreciate reviews of this change to delete unused adaptive size
> policy code for cms and parnew.  It's big in terms of line count, but
> most comes from the deletion of 6 files.
> 
> http://cr.openjdk.java.net/~jcoomes/8034246-rm-cms-asp/

Good to get rid of code that hasn't been working for a while.

In src/share/vm/memory/collectorPolicy.cpp the include statement:
#include "gc_implementation/shared/adaptiveSizePolicy.hpp"
is already present a few lines up.


CMSCollector::size_policy and ConcurrentMarkSweepGeneration::size_policy are 
basically identical now, do you want to fix this now or leave this as just a 
code removal change? (personally, I'm fine either way)

Consider the change reviewed nevertheless.

/Mikael


> 
> -John



More information about the hotspot-gc-dev mailing list