RFR (L) 8034246: remove CMS and ParNew adaptive size policy code

John Coomes John.Coomes at oracle.com
Wed May 7 04:36:04 UTC 2014


Thomas Schatzl (thomas.schatzl at oracle.com) wrote:
> Hi John,
> 
> On Mon, 2014-05-05 at 09:14 -0700, John Coomes wrote:
> > I'd appreciate reviews of this change to delete unused adaptive size
> > policy code for cms and parnew.  It's big in terms of line count, but
> > most comes from the deletion of 6 files.
> > 
> > http://cr.openjdk.java.net/~jcoomes/8034246-rm-cms-asp/
> > 
> > -John
> 
>   some notes:
> 
> - the GCPauseTimer class can be removed now too I think. This change
> removes its last uses.

Thanks for spotting that; I removed it.

> - in CMSCollector::reset(), I am not sure why the
> AdaptiveSizePolicyOutput use has been removed, and the change in
> AdaptiveSizePolicyOutput::print_test(). Same in
> GenCollectedHeap::do_collection().

The ASPOutput class was only active when AdaptiveSizePolicy and either
ParallelGC or CMS was enabled.  CMS forces AdaptiveSizePolicy off, so
it is effectively ParallelGC only.

>                                    If that is intendeded, can we remove
> the local "sp" variable in CMSCollector::reset(), i.e. inline it? It's
> only used once quite far below.
> That's just a suggestion, I am fine with either way.

Sure, I removed sp.  Updated webrev at the same location.

> Otherwise looks good.

Thanks!

-John


More information about the hotspot-gc-dev mailing list