RFR (L) 8034246: remove CMS and ParNew adaptive size policy code

Srinivas Ramakrishna ysr1729 at gmail.com
Wed May 7 06:37:53 UTC 2014


Looks good to me too, and good that we are able to remove code that hasn't been used and seems unlikely now, with G1 available, to have the resources to make it work well. Please make sure that this has also been approved by Jon.

Reviewed.
-- Ramki

ysr1729

> On May 6, 2014, at 21:38, John Coomes <John.Coomes at oracle.com> wrote:
> 
> Mikael Gerdin (mikael.gerdin at oracle.com) wrote:
>> John,
>> 
>>> On Monday 05 May 2014 09.14.40 John Coomes wrote:
>>> I'd appreciate reviews of this change to delete unused adaptive size
>>> policy code for cms and parnew.  It's big in terms of line count, but
>>> most comes from the deletion of 6 files.
>>> 
>>> http://cr.openjdk.java.net/~jcoomes/8034246-rm-cms-asp/
>> 
>> Good to get rid of code that hasn't been working for a while.
>> 
>> In src/share/vm/memory/collectorPolicy.cpp the include statement:
>> #include "gc_implementation/shared/adaptiveSizePolicy.hpp"
>> is already present a few lines up.
> 
> Yes; fixed.
> 
>> CMSCollector::size_policy and ConcurrentMarkSweepGeneration::size_policy are 
>> basically identical now, do you want to fix this now or leave this as just a 
>> code removal change? (personally, I'm fine either way)
> 
> The ConcurrentMarkSweepGeneration one is no longer used, so I removed
> it.  Updated webrev is at the same location.
> 
>> Consider the change reviewed nevertheless.
> 
> Thanks!
> 
> -John


More information about the hotspot-gc-dev mailing list