RFR: 8062537: [TESTBUG] Conflicting GC combinations in hotspot tests

Jon Masamitsu jon.masamitsu at oracle.com
Mon Nov 3 18:14:53 UTC 2014


One suggestion on this review.


This part of comment should be deleted.

   33  * Test the output of G1SummarizeRSetStats in conjunction with G1SummarizeRSetStatsPeriod.

The test doesn't use G1.


On 10/30/2014 07:05 AM, Evgeniya Stepanova wrote:
> Hi,
> Please review changes for 8062537, the OpenJDK/hotspot part of the 
> JDK-8019361 <https://bugs.openjdk.java.net/browse/JDK-8019361>
> bug: https://bugs.openjdk.java.net/browse/JDK-8062537
> fix: http://cr.openjdk.java.net/~eistepan/8062537/webrev.00/
> Problem: Some tests explicitly set GC and fail when jtreg set another GC.
> Solution: Such tests marked with the jtreg tag "requires" to skip test 
> if there is a conflict
> Tested locally with different GC flags (-XX:+UseG1GC, 
> -XX:+UseParallelGC, -XX:+UseSerialGC, -XX:+UseConcMarkSweep and 
> without any GC flag). Tests are being excluded as expected. No tests 
> failed because of the conflict.
> Thanks,
> Evgeniya Stepanova

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20141103/d1cd8707/attachment.html>

More information about the hotspot-gc-dev mailing list