RFR: 8061467: Bad page size passed to setup_large_pages() on Solaris

Thomas Schatzl thomas.schatzl at oracle.com
Wed Nov 5 15:14:25 UTC 2014


Hi all,

  since Erik is on vacation and this bug prevents a lot of tests from
running, I took over and added a (simple) regression test case.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8061467

Webrev:
http://cr.openjdk.java.net/~tschatzl/8061467/webrev/

Testing:
jprt, Solaris numa machine showing the crash before, and no crash after
the change, local testing, jprt test case runs

Since the test is extremely simple (class with empty main method), I am
going to keep Erik as the original author of this change as his change
is the one that required the hard work.

Thanks,
  Thomas

On Tue, 2014-11-04 at 13:09 +0100, Thomas Schatzl wrote:
> Hi Erik,
> 
> On Tue, 2014-10-28 at 19:10 +0100, Erik Helin wrote:
> > Hi all,
> > 
> > this small patch fixes a call to Solaris::setup_large_pages that does 
> > not check if the `alignment_hint` parameter is a valid page size (the 
> > only such call left).
> > 
> > Webrev:
> > http://cr.openjdk.java.net/~ehelin/8061467/webrev.00/
> > 
> > Bug:
> > https://bugs.openjdk.java.net/browse/JDK-8061467
> > 
> > Testing:
> > - Verified that the fix solves the issue on a Solaris machine that
> >    supported NUMA.
> > - JPRT
> 
>   looks good. Could you add a simple regression test like the one
> suggested in the CR?
> 
> Thanks,
>   Thomas
> 
> 




More information about the hotspot-gc-dev mailing list