RFR: 8062036: ConcurrentMarkThread::slt may be invoked before ConcurrentMarkThread::makeSurrogateLockerThread causing intermittent crashes

Kim Barrett kim.barrett at oracle.com
Fri Nov 7 17:33:12 UTC 2014


On Nov 7, 2014, at 10:42 AM, Bengt Rutisson <bengt.rutisson at oracle.com> wrote:
> 
> Yes, I totally agree. The current @requires functionality is not enough for our needs. I pointed this out in the recent review request to add the @requires tag to many GC tests. And I pointed that out when the @requires tag was first suggested about a year ago. Unfortunately this feedback has been left out for some reason.

It was by following along with that review that I became aware of the possible pitfalls with @requires, which helped me recognize the difficulties with this particular case.   I wonder how common tests with multiple @run lines that might have different requirements are, or could be in the future?  That seems like it could happen sufficiently frequently that I think I will file another bug against the @requires feature.

> Anyway, I think it would be good to explicitly add the GC to the @run command. Otherwise these tests will be run in many places, nightly testing for the other groups, PIT testing, manual testing, ad hoc aurora runs, et.c. without actually testing anything.
> 
> Since the test is so simple I think splitting it up into two files is the simplest workaround for the @requires limitation for now.

Thinking about this more overnight, I was approaching the same conclusion; so that’s what I’ll do.

Thanks for your review and helpful discussion.



More information about the hotspot-gc-dev mailing list