RFR (XXS): 8064348: Add TraceEvent::is_enabled() for embedded/minimal builds

Marcus Larsson marcus.larsson at oracle.com
Mon Nov 10 08:37:51 UTC 2014


Hi,

I somehow managed to add the const qualifier to this method although it 
shouldn't be there.
Updated webrev (without the const):
http://cr.openjdk.java.net/~mlarsson/8064348/webrev.01/

Thanks,
Marcus

On 07/11/14 20:49, Staffan Larsen wrote:
>> On 7 nov 2014, at 16:40, Erik Helin <erik.helin at oracle.com> wrote:
>>
>> Hi Markus,
>>
>> looks good, Reviewed. I can sponsor this change.
>>
>> If it is ok for the svc team, I would like to push this via the jdk9/hs-gc/hotspot repo (not via jdk9/hs-rt/hotspot) since we have other upcoming patches depending on this one.
> That is ok with me if you do a jprt run with the jdk_jfr tests.
>
> /Staffan
>
>> Thanks,
>> Erik
>>
>> On 2014-11-07 16:32, Marcus Larsson wrote:
>>> Hi,
>>>
>>> Can I please have reviews for the following small patch to enable usage
>>> of TraceEvent::is_enabled() even when INCLUDE_TRACE is not defined?
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~mlarsson/8064348/webrev.00/
>>>
>>> Bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8064348
>>>
>>> Thanks,
>>> Marcus



More information about the hotspot-gc-dev mailing list