RFR (S): Forward-port: 7176220 'Full GC' events miss date stamp information occasionally
andreas.eriksson at oracle.com
Fri Nov 14 13:05:15 UTC 2014
Thanks for the review!
On 2014-11-14 13:33, Bengt Rutisson wrote:
> Hi Andreas,
> Looks good.
> Thanks for fixing this!
> On 2014-11-14 13:28, Andreas Eriksson wrote:
>> This fix was actually pushed to jdk7/hsx24 over a year ago by me.
>> IIRC the push to jdk8/hsx25 was delayed at the time, over fears that
>> it would conflict with the big metaspace change and/or JFR work that
>> was about to get pushed.
>> Unfortunately I then forgot all about it.
>> I would like to push this fix to jdk9 (and then jdk8) now.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-7176220
>> The problem is that CMS sometimes misses datestamps for time trace
>> The fix is to move the datestamp print logic into the class that
>> handles time trace printouts, GCTraceTime.
>> This makes it consistent with timestamps, which are already printed
>> from there.
>> Webrev for jdk9:
>> And for reference:
>> hsx24 review thread:
>> hsx24 changeset:
More information about the hotspot-gc-dev