RFR: 8065227: Report allocation context stats at end of cleanup

Mikael Gerdin mikael.gerdin at oracle.com
Thu Nov 20 12:28:17 UTC 2014


Hi Stefan,

On 2014-11-20 10:14, Stefan Johansson wrote:
> Hi Jon,
>
> Thanks for taking a look at this change.
>
> On 2014-11-20 04:32, Jon Masamitsu wrote:
>> Stefan,
>>
>> Why did you chose to rename update_at_remark() to update_after_mark()?
>> Instead of update_at_cleanup()?
> Changing it to update_at_cleanup() was my first thought, but I think
> update_after_mark() is more descriptive and a better fit when looking
> how its implemented.

Looks good to me, I'm fine with either naming variant.

/Mikael

>
> Thanks,
> Stefan
>>
>> Jon
>>
>> On 11/19/2014 9:00 AM, Stefan Johansson wrote:
>>> Hi,
>>>
>>> Please review this small fix for:
>>> https://bugs.openjdk.java.net/browse/JDK-8065227
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~sjohanss/8065227/hotspot.00/
>>>
>>> Summary:
>>> The update for the allocation context has previously been done in the
>>> remark phase but this is a little to early. The last stw-phase of the
>>> marking cycle is the cleanup and if doing the reporting there that
>>> simplifies.
>>>
>>> Thanks,
>>> Stefan
>>>
>>>
>>
>


More information about the hotspot-gc-dev mailing list