Need a sponsor for push into jdk9/hs-gc

Alexander Harlap alexander.harlap at oracle.com
Thu Nov 20 15:16:52 UTC 2014


Thank you Jesper,

8059492.patch attached.

Alex

On 11/19/2014 5:29 PM, Jesper Wilhelmsson wrote:
> Hi Alex,
>
> If you haven't found anyone already I can push this. Do an "hg export" 
> of your outgoing change and send me the diff.
> /Jesper
>
>
> Alexander Harlap skrev 19/11/14 17:55:
>> I need a sponsor to push this (reviewed by Mikael Gerdin) trivial change.
>> My jdk username is aharlap.
>>
>> Change passed JPRT build, test and failed on push because I do not 
>> have commiter rights.
>>
>> Thank you,
>>
>> Alex
>>
>>
>> -------- Original Message --------
>> Subject: 	Re: Review request for 8059492: Wrong spelling in assert: 
>> "Not initialied properly?"
>> Date: 	Tue, 18 Nov 2014 19:49:13 +0100
>> From: 	Mikael Gerdin <mikael.gerdin at oracle.com>
>> Organization: 	Oracle Corporation
>> To: 	Alexander Harlap <alexander.harlap at oracle.com>, 
>> jdk9-dev at openjdk.java.net
>>
>>
>>
>> Hi Alex,
>>
>> On 2014-11-18 17:29, Alexander Harlap wrote:
>> > Please help to code review the change in JDK9 (trivial) for the
>> > following CR:
>> > 8059492: Wrong spelling in assert: "Not initialied properly?"
>> >https://bugs.openjdk.java.net/browse/JDK-8059492
>> >
>> > The webrev is located at:
>> >http://cr.openjdk.java.net/~aharlap/8059492/webrev.00/
>> ><http://cr.openjdk.java.net/%7Eaharlap/8059492/webrev.00/>
>>
>> The change looks good to me, Reviewed.
>>
>> /Mikael
>>
>> >
>> > Testing completed: JPRT
>> >
>> > Alex
>>
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20141120/1d128fb0/attachment.html>
-------------- next part --------------
# HG changeset patch
# User aharlap
# Date 1416495802 18000
# Node ID 9ba7b1be98b7333d5f725d044d1aa6058ddbeb47
# Parent  898c20a0184e72610670d0463e5052725f792b10
8059492: Wrong spelling in assert: "Not initialied properly?"
Reviewed-by: mgerdin
Contributed-by: aharlap <alexander.harlap. at oracle.com>

diff -r 898c20a0184e -r 9ba7b1be98b7 src/share/vm/memory/metaspace.cpp
--- a/src/share/vm/memory/metaspace.cpp	Tue Nov 18 12:33:47 2014 +0000
+++ b/src/share/vm/memory/metaspace.cpp	Thu Nov 20 10:03:22 2014 -0500
@@ -1412,7 +1412,7 @@
 
 size_t MetaspaceGC::capacity_until_GC() {
   size_t value = (size_t)OrderAccess::load_ptr_acquire(&_capacity_until_GC);
-  assert(value >= MetaspaceSize, "Not initialied properly?");
+  assert(value >= MetaspaceSize, "Not initialized properly?");
   return value;
 }
 


More information about the hotspot-gc-dev mailing list