RFR: 8065749: [TESTBUG]: gc/arguments/TestG1HeapRegionSize.java fails at nightly
bengt.rutisson at oracle.com
Mon Nov 24 14:33:12 UTC 2014
On 2014-11-24 14:13, Evgeniya Stepanova wrote:
> Could you please review changes for 8065749 ?
> Test TestG1HeapRegionSize.java is G1-specific and could not work
> without -XX:+UseG1GC passed directly.
> Option added to the run.
> bug: https://bugs.openjdk.java.net/browse/JDK-8065749
> fix: http://cr.openjdk.java.net/~eistepan/8065749/webrev.00/
I think your suggested fix will work, but I have a question regarding
the original change.
Before the original change the test explicitly checked that it was run
with G1 and just skipped otherwise:
Was this test really failing at all? I thought we were only going to add
@requires to tests that were failing due to conflicting GC combinations.
If it was working before I think a different approach to fix the current
problem would be to revert back to the old code without @requires.
> Evgeniya Stepanova
> /Evgeniya Stepanova/
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-gc-dev