RFR: 8065749: [TESTBUG]: gc/arguments/TestG1HeapRegionSize.java fails at nightly

Bengt Rutisson bengt.rutisson at oracle.com
Mon Nov 24 14:33:12 UTC 2014


Hi Evgeniya,

On 2014-11-24 14:13, Evgeniya Stepanova wrote:
> Hi,
>
> Could you please review changes for 8065749 ?
> Test TestG1HeapRegionSize.java is G1-specific and could not work 
> without -XX:+UseG1GC passed directly.
> Option added to the run.
> bug: https://bugs.openjdk.java.net/browse/JDK-8065749
> fix: http://cr.openjdk.java.net/~eistepan/8065749/webrev.00/

I think your suggested fix will work, but I have a question regarding 
the original change.

Before the original change the test explicitly checked that it was run 
with G1 and just skipped otherwise:

http://hg.openjdk.java.net/jdk9/hs-gc/hotspot/comparison/6464714dd742/test/gc/arguments/TestG1HeapRegionSize.java

Was this test really failing at all? I thought we were only going to add 
@requires to tests that were failing due to conflicting GC combinations. 
If it was working before I think a different approach to fix the current 
problem would be to revert back to the old code without @requires.

Thanks,
Bengt

>
> Thanks,
> Evgeniya Stepanova
>
> -- 
> /Evgeniya Stepanova/
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20141124/38d22adc/attachment.html>


More information about the hotspot-gc-dev mailing list