RFR [2/2] 8065258: JDK-8065358 Refactor G1s usage of save_marks and reduce related races

Mikael Gerdin mikael.gerdin at oracle.com
Wed Nov 26 12:26:49 UTC 2014


Thanks Bengt and Thomas for the reviews, I plan to push this together 
with the CMS member variable change now.

/Mikael

On 2014-11-26 11:45, Thomas Schatzl wrote:
> Hi,
>
> On Thu, 2014-11-20 at 14:24 +0100, Mikael Gerdin wrote:
>> Hi,
>>
>> (I just noticed that I mistyped the bug number in the subject, it should
>> be 8065358 twice.)
>>
>> I removed the weird qualifier combination from "st" in record_timestamp().
>>
>> Thomas also suggested to me that the guarantee in record_retained_region
>> may in fact be incorrect in some corner cases, I removed it since no
>> other part of the code actually depends on this being true.
>>
>> New webrev at:
>> http://cr.openjdk.java.net/~mgerdin/8065358/webrev.1/
>> Incremental webrev at:
>> http://cr.openjdk.java.net/~mgerdin/8065358/webrev.0_to_1/
>>
>
> Looks good. Thanks.
>
> Thomas
>
>


More information about the hotspot-gc-dev mailing list