RFR 8065579: WB method to start G1 concurrent mark cycle should be introduced

Thomas Schatzl thomas.schatzl at oracle.com
Thu Nov 27 08:25:03 UTC 2014


Hi,

On Thu, 2014-11-27 at 02:10 +0300, Leonid Mesnik wrote:
> Stefan
> 
> Thank you for review. 
> 
> Could I have review from Reviewer for this fix?

- gcCause.cpp:

Is it possible to let the human readable string be similar to the
others? I.e. "WhiteBox Initiated Concurrent Mark" instead of "WhiteBox
Initiated ConcurrentMarkCycle"?

- WhiteBox.java:

In the comment, please start sentences with capital letters. Also add
punctuation if it is a full sentence. All but this and the "force xy GC"
follow this style.

- TestConcMarkCycleWB.java

The test needs to install sun.hotspot.WhiteBox$WhiteBoxPermission too.
There is a typo in the @summary line: relatd->related

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list