RFR 8065579: WB method to start G1 concurrent mark cycle should be introduced

Thomas Schatzl thomas.schatzl at oracle.com
Thu Nov 27 13:17:54 UTC 2014


Hi all,

On Thu, 2014-11-27 at 09:25 +0100, Thomas Schatzl wrote: 
> Hi,
> 
> On Thu, 2014-11-27 at 02:10 +0300, Leonid Mesnik wrote:
> [...]
> > Could I have review from Reviewer for this fix?
> 
> - gcCause.cpp:
> 
> Is it possible to let the human readable string be similar to the
> others? I.e. "WhiteBox Initiated Concurrent Mark" instead of "WhiteBox
> Initiated ConcurrentMarkCycle"?
> 
> - WhiteBox.java:
> 
> In the comment, please start sentences with capital letters. Also add
> punctuation if it is a full sentence. All but this and the "force xy GC"
> follow this style.
> 
> - TestConcMarkCycleWB.java
> 
> The test needs to install sun.hotspot.WhiteBox$WhiteBoxPermission too.
> There is a typo in the @summary line: relatd->related
> 

 Leonid asked me to put up a new webrev with the suggested fixes plus
fixes of the copyright header in the test, and addition of the @bug tag
in the same.

Here is the new webrev:
http://cr.openjdk.java.net/~tschatzl/8065579-leonid/webrev/

I will sponsor the change.

Thanks,
  Thomas




More information about the hotspot-gc-dev mailing list