RFR (S): 8066102: Clean up HeapRegionRemSet files

Mikael Gerdin mikael.gerdin at oracle.com
Fri Nov 28 12:10:00 UTC 2014


Hi Thomas,

On 2014-11-28 09:46, Thomas Schatzl wrote:
> Hi all,
>
>    can I have reviews for this small cleanup? I went over heap region
> remembered set files recently and found dead code, useless code,
> tightened the public interface and tried to document the methods a
> little. I also moved FromCardCache accessor methods from
> OtherRegionTable to HeapRegionRemSet to do away with that needless
> indirection. Imo it fits better that way too.
>
> CR:
> https://bugs.openjdk.java.net/browse/JDK-8066102
>
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8066102/webrev/

In heapRegionRemSet.hpp:
+  // One bits in the bitmaps indicate that the given region or card is 
live.
typo: "One bit in one of the bitmaps indicate that the.."

Otherwise the change looks good to me.

/Mikael

>
> Testing:
> jprt
>
> Thanks,
>    Thomas
>


More information about the hotspot-gc-dev mailing list