RFR (XS): 8059527: Disallow ParallelGCThreads=0 for G1
marcus.larsson at oracle.com
Thu Oct 2 07:22:43 UTC 2014
Thank you for the input.
On 01/10/14 16:48, Erik Helin wrote:
> Hi Marcus,
> a couple of comments:
> - src/share/vm/runtime/arguments.cpp:
> Could you use vm_exit_during_initialization instead of vm_exit?
> This way, the error message will be printed in a uniform way and the
> VM will also run all shutdown functions (such as os::shutdown,
> os::abort etc).
> - test/gc/arguments/TestParallelGCThreads.java
> + * @build TestParallelGCThreads FlagsValue
> I don't believe this line is needed, jtreg should automically build
> your files
> + * @run main/othervm TestParallelGCThreads
> Please use `@run driver` instead of `@run main/othervm`. You can use
> 'driver' because your tests creates its own processes.
> Please use assertions from the testlibrary instead of throwing a
> - Please update hotspot/test/TEST.groups to include your new test for
> needs_g1gc, needs_parallelgc and needs_cmsgc
> On 2014-10-01 15:22, Marcus Larsson wrote:
>> Can I have reviews for the following small patch disallowing
>> ParallelGCThreads to be 0 when G1 is used? Also included a small test to
>> verify that the VM will not start if the count is 0 for parallel
>> collectors (G1, CMS+ParNew and ParallelGC).
More information about the hotspot-gc-dev