RFR (S): 8059758: Startup benchmark performance and footprint regressions with JDK-8038423

Jesper Wilhelmsson jesper.wilhelmsson at oracle.com
Mon Oct 6 13:06:05 UTC 2014


Thanks for adding the comments!
Ship it!
/Jesper


Thomas Schatzl skrev 6/10/14 14:25:
> Hi,
>
>    thanks for the review.
>
> On Mon, 2014-10-06 at 14:23 +0200, Jesper Wilhelmsson wrote:
>> Looks good!
>>
>> Maybe add a comment about why the newly added argument is not used in
>>
>> G1RegionMappingChangedListener::on_commit()
>>
>> and
>>
>> G1SATBCardTableLoggingModRefBSChangedListener::on_commit()
>>
>    added :)
>
> Webrev:
> http://cr.openjdk.java.net/~tschatzl/8059758/webrev.1/
> Webrev from last:
> http://cr.openjdk.java.net/~tschatzl/8059758/webrev.0_to_1/
>
> Thanks,
>    Thomas
>
>



More information about the hotspot-gc-dev mailing list