RFR (S): JDK-8058801: G1TraceReclaimDeadHumongousObjectsAtYoungGC only prints humongous object liveness output when there is at least one candidate humongous object

Thomas Schatzl thomas.schatzl at oracle.com
Wed Oct 8 10:58:29 UTC 2014


Hi,

On Tue, 2014-10-07 at 16:37 -0700, Sangheon Kim wrote:
> Hi all, 
> 
> can I have reviews for the following small change to print humongous
> objects information
> even though there's no candidates for humongous object? 
> 
> Main changes are: 
> 1) Not to skip humongous reclaim phase if
> 'G1TraceReclaimDeadHumongousObjectsAtYoungGC' is set.
> 2) Changed to print humongous object size. 
> 3) Added jtreg test case to test whether it prints Humongous object
> information correctly or not.
> 
> Please ignore wrong test log(line:56, 80) at
> TestG1TraceReclaimDeadHumongousObjectsAtYoungGC.java

I uploaded a fixed version with these lines removed at the same
location.
> 
> CR: 
> https://bugs.openjdk.java.net/browse/JDK-8058801
> 
> Webrev: 
> http://cr.openjdk.java.net/~tschatzl/8058801-kim/webrev/ 

Please set -XX:G1HeapRegionSize=1M in the tests to avoid potential
future problems with changed defaults.

Looks good to me.

Thanks,
  Thomas





More information about the hotspot-gc-dev mailing list