RFR (S): 8043243: convert SCAN_AND_FORWARD, SCAN_AND_ADJUST_POINTERS, SCAN_AND_COMPACT macros to methods

Marcus Larsson marcus.larsson at oracle.com
Mon Oct 27 14:29:33 UTC 2014


Hi again,

Apparently MSVC has some problems with the inline keyword and friend 
declarations on the specialized function templates, and therefore the 
latest patch wouldn't compile on windows. Resolved this by making the 
friend declarations non-specialized.

Now builds & runs fine on all platforms in JPRT.

New webrev:
http://cr.openjdk.java.net/~mlarsson/8043243/webrev.02/

Incremental:
http://cr.openjdk.java.net/~mlarsson/8043243/webrev.01-02/

Thanks,
Marcus

On 27/10/14 09:26, Marcus Larsson wrote:
> Hi,
>
> On 24/10/14 20:18, Kim Barrett wrote:
>> [Didn’t like my ScanSupport helper class?  Well, it was an interesting
>> little exercise for me anyway.]
>>
>
> I wanted to avoid CRTP solutions for now. Your sketch might be a good
> reference for possible future changes though.
>
>>
>> This latest version looks good.
>>
>
> Thank you for the review!
>
> Marcus


More information about the hotspot-gc-dev mailing list