RFR (S): 8043243: convert SCAN_AND_FORWARD, SCAN_AND_ADJUST_POINTERS, SCAN_AND_COMPACT macros to methods

Kim Barrett kim.barrett at oracle.com
Mon Oct 27 17:22:54 UTC 2014


On Oct 27, 2014, at 10:29 AM, Marcus Larsson <marcus.larsson at oracle.com> wrote:
> 
> Apparently MSVC has some problems with the inline keyword and friend declarations on the specialized function templates, and therefore the latest patch wouldn't compile on windows. Resolved this by making the friend declarations non-specialized.
> 
> Now builds & runs fine on all platforms in JPRT.
> 
> New webrev:
> http://cr.openjdk.java.net/~mlarsson/8043243/webrev.02/
> 
> Incremental:
> http://cr.openjdk.java.net/~mlarsson/8043243/webrev.01-02/

Sorry to hear that.  The updated code change looks good.  It might be nice to leave a comment indicating the workaround though.



More information about the hotspot-gc-dev mailing list