RFR: 8062537: [TESTBUG] Conflicting GC combinations in hotspot tests

Jon Masamitsu jon.masamitsu at oracle.com
Fri Oct 31 03:45:08 UTC 2014


Evgeniya,

I've only look at a few of the files.  I'm not sure
I'm interpreting the @requires correctly.  If you
reply to these initial comments, that will help
me understand.

http://cr.openjdk.java.net/~eistepan/8062537/webrev.00/test/gc/arguments/TestMaxNewSize.java.udiff.html

+ * @requires vm.gc=="null"

Test seems to expect Serial GC.  Should the requires
be Serial or null?

http://cr.openjdk.java.net/~eistepan/8062537/webrev.00/test/gc/arguments/TestSerialHeapSizeFlags.java.udiff.html

Comments say this is a test of Serial but null
allowed.

+ * @requires vm.gc=="Serial" | vm.gc=="null"


http://cr.openjdk.java.net/~eistepan/8062537/webrev.00/test/gc/class_unloading/TestCMSClassUnloadingEnabledHWM.java.udiff.html

If you're going to use this on all the collectors (allow vm.gc == null),
then class loading should be turned off on all the GC's, not
just CMS (-XX:-CMSClassUnloadingEnabled only affects CMS).

Jon

On 10/30/2014 07:05 AM, Evgeniya Stepanova wrote:
> Hi,
>
> Please review changes for 8062537, the OpenJDK/hotspot part of the 
> JDK-8019361 <https://bugs.openjdk.java.net/browse/JDK-8019361>
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8062537
> fix: http://cr.openjdk.java.net/~eistepan/8062537/webrev.00/
>
> Problem: Some tests explicitly set GC and fail when jtreg set another GC.
> Solution: Such tests marked with the jtreg tag "requires" to skip test 
> if there is a conflict
>
> Tested locally with different GC flags (-XX:+UseG1GC, 
> -XX:+UseParallelGC, -XX:+UseSerialGC, -XX:+UseConcMarkSweep and 
> without any GC flag). Tests are being excluded as expected. No tests 
> failed because of the conflict.
>
> Thanks,
> Evgeniya Stepanova
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20141030/374347b8/attachment.html>


More information about the hotspot-gc-dev mailing list