RFR: 8026043: Add regression test for JDK-8000831

Evgeniya Stepanova evgeniya.stepanova at oracle.com
Wed Apr 1 14:45:23 UTC 2015


Hi Mandy,

Thank you for the review!
Jane
On 01.04.2015 17:40, Mandy Chung wrote:
>
> On 4/1/2015 3:49 AM, Evgeniya Stepanova wrote:
>> Hi Mandy!
>>
>> Thanks for looking at this
>> One of the testlibrary classes used is depends on java.management. 
>> Added tag @modules
>>
>> new webrev: http://cr.openjdk.java.net/~eistepan/8026043/webrev.01
>>
>
> Thanks. Looks okay to me.
>
> Nit: There are a few long lines that you may consider breaking them.
> No need for an updated webrev.
>
> Mandy
>
>> Thanks,
>> Jane
>>
>> On 31.03.2015 19:25, Mandy Chung wrote:
>>> Does this need any @modules tag?
>>>
>>> Mandy
>>>
>>> On 3/31/15 7:10 AM, Evgeniya Stepanova wrote:
>>>> Hi all,
>>>>
>>>> Could you please review fix for 8026043? It is a regression test 
>>>> for 8000831: Heap verification output incorrect/incomplete. Test 
>>>> check that gc log contains expected information
>>>> Originally patch was performed by Filipp Zhinkin in [1] , but 
>>>> review process was never finished.
>>>> Test adapted to use current testlibrary functionality.
>>>>
>>>> bug: https://bugs.openjdk.java.net/browse/JDK-8026043
>>>> webrev: http://cr.openjdk.java.net/~eistepan/8026043/webrev.00/
>>>> [1] 
>>>> http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2013-October/008772.html
>>>>
>>>> Thanks,
>>>> Jane
>>>>
>>>
>>
>> -- 
>> /Evgeniya Stepanova/
>

-- 
/Evgeniya Stepanova/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20150401/7b7eaa8e/attachment-0001.html>


More information about the hotspot-gc-dev mailing list