RFR: 8073669: gc/TestSoftReferencesBehaviorOnOOME.java times out in nightlies

Thomas Schatzl thomas.schatzl at oracle.com
Thu Apr 2 12:07:14 UTC 2015


Hi Andrey,

  sorry for the late reply....

On Thu, 2015-04-02 at 14:44 +0300, Andrey Zakharov wrote:
> Hi, team. Could you, please, review this?
> Thanks.
> 
> 
> On 16.03.2015 15:57, Andrey Zakharov wrote:
> > Hi, team.
> > I've
> >     changed test scenario to more straight-forward one,
> >     added tricks to prevent compiler optimizations and
> >     added checks when OOME didn't thrown as expected.
> >
> > webrev:
> >     http://cr.openjdk.java.net/~azakharov/8073669/webrev/
> > testbug:
> >     https://bugs.openjdk.java.net/browse/JDK-8073669
> >
> > testing: done in jprt, looks good now.
> >

- Line 72 in the new version is superfluous and serves no purpose.

- I do not understand the reason for line 108 in conjunction with the
comment above that. There should not be another OOME caused by this
because the test makes the space occupied by the dummy objects available
before that.
Sure, it is good to get the size of the array before nulling it out
later, but I cannot see the connection with "causing an OOME".

- in main(), is it possible to give the declaration of maxSize its own
type? Otherwise, maxSize is just oddly indented.

Otherwise looks okay.

Thanks,
  Thomas
 




More information about the hotspot-gc-dev mailing list