RFR (S): JDK-8076241: Remove unused methods mod_card_iterate() and non_clean_card_iterate_serial()

Bengt Rutisson bengt.rutisson at oracle.com
Thu Apr 2 20:53:54 UTC 2015


On 02/04/15 17:48, Kim Barrett wrote:
> Hit send too soon on previous message, and forgot to reply to the important part.
>
> On Apr 2, 2015, at 11:44 AM, Kim Barrett <kim.barrett at oracle.com> wrote:
>>>> I think the only one left is ClearNoncleanCardWrapper::do_MemRegion().  But I don’t guarantee there aren’t more.
>>> Thanks for pointing this out.
>>>
>>> As I mentioned before I'm happy to push a fix to add the comment back. Do you think this would be appropriate?
>>>
>>> diff --git a/src/share/vm/memory/cardTableRS.cpp b/src/share/vm/memory/cardTableRS.cpp
>>> --- a/src/share/vm/memory/cardTableRS.cpp
>>> +++ b/src/share/vm/memory/cardTableRS.cpp
>>> @@ -176,7 +176,10 @@
>>> bool ClearNoncleanCardWrapper::is_word_aligned(jbyte* entry) {
>>>   return (((intptr_t)entry) & (BytesPerWord-1)) == 0;
>>> }
>>> -
>>> +// The regions are visited in *decreasing* address order.
>>> +// This order aids with imprecise card marking, where a dirty
>>> +// card may cause scanning, and summarization marking, of objects
>>> +// that extend onto subsequent cards.
>>> void ClearNoncleanCardWrapper::do_MemRegion(MemRegion mr) {
>>>   assert(mr.word_size() > 0, "Error");
>>>   assert(_ct->is_aligned(mr.start()), "mr.start() should be card aligned”);
> Yes, that looks good.

Thanks, Kim. I just sent out a review request to add this comment back.

Bengt

>



More information about the hotspot-gc-dev mailing list