RFR (S): 8074546: Rename and clean up the ParGCAllocBuffer class

Kim Barrett kim.barrett at oracle.com
Fri Apr 3 18:22:32 UTC 2015


On Apr 3, 2015, at 1:32 PM, Kim Barrett <kim.barrett at oracle.com> wrote:
> 
> On Apr 3, 2015, at 11:30 AM, Joseph Provino <joseph.provino at oracle.com> wrote:
>> 
>> ParGCAllocBuffer is changed to PLAB and G1ParGCAllocBuffer is changed to G1PLAB.
>> 
>> parGCAllocBuffer.* is changed to plab*.
>> 
>> CR:  https://bugs.openjdk.java.net/browse/JDK-8074546
>> 
>> webrev:  http://cr.openjdk.java.net/~jprovino/8074546/webrev.00
>> 
>> Test:  jprt
> 
> Looks good.

Foo!  I got interrupted and forgot I had a couple of minor comments.

------------------------------------------------------------------------------ 
src/share/vm/gc_implementation/shared/plab.hpp
  25 #ifndef SHARE_VM_GC_IMPLEMENTATION_PARNEW_PLAB_HPP
  26 #define SHARE_VM_GC_IMPLEMENTATION_PARNEW_PLAB_HPP
...
 197 #endif // SHARE_VM_GC_IMPLEMENTATION_PARNEW_PLAB_HPP

PARNEW => SHARED

[Apparently that didn't get updated when the file was moved from /parNew/
to /shared/ several years ago.]

------------------------------------------------------------------------------
src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
  42 #include "gc_implementation/shared/plab.hpp"

Since there are no other changes in this file, I think this include
isn't needed at all by this file.  Of course, taking it out might
uncover places that should be including it but aren't...




More information about the hotspot-gc-dev mailing list